Use compile_dir to compile #12907
Closed
Use compile_dir to compile #12907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notatallshaw
force-pushed
the
use-compile_dir-to-compile
branch
from
e80dc8d
to
3762ddc
Compare
|
Hmmm, to keep pip's current behavior, I think I'm going to have to make a utility function called It's more complexity but the time savings are relatively quite large. |
|
This is going to need a bit of a different approach, but I have a good idea, I'll make a new PR at some point. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft implementation of my idea here #12712 (comment)
However, currently it fails to supress SyntaxWarnings when compiling, it will stay in draft until I figure out how to fix that. There are also probably edge cases I haven't thought of.
Performance improvement on my synthetic test in #12712 (comment) shows a 25 second improvement on my machine.