-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that removing shim in older setuptools does not error #11315
Conversation
Also, if Not sure what to do here. Any suggestion @jaraco @pradyunsg ? |
If The issue appears to be that some form of downgrade of Setuptools is leading to an empty Separately, it would be nice to understand why a downgrade is leading to directories left behind. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If remove_shim is absent, it probably means that the shim isn't present, so it's fine. I confirmed that the first appearance of _distutils_hack in 49.3.0 had remove_shim.
Thanks for the analysis, @jaraco !
news/11314.bugfix.rst
Outdated
@@ -0,0 +1 @@ | |||
Avoid AttributeError when _distutils_hack is missing its implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid AttributeError when _distutils_hack is missing its implementation. | |
Avoid ``AttributeError`` when removing the setuptools-provided ``_distutils_hack`` is missing its implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that be:
Avoid AttributeError
when removing the setuptools-provided _distutils_hack
and it is missing its implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdrosen96 can you please update the news fragment as you suggest and squash the commits in this PR? This will then go in 22.2.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
9544c56
to
50eb337
Compare
Addresses #11314