Pass --disable-pip-version-check in tests #11135
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
reviewed
May 22, 2022
Pass `--disable-pip-version-check` when running pip from the test suite. In the best case, these checks are unnecessary and in the worst, they cause tests to fail by emitting warnings. Fixes pypa#11114
mgorny
force-pushed
the
disable-version-check
branch
from
a0080d2 to
8f94bdc
Compare
|
Probably easier to set the environment variable instead? |
jbylund
reviewed
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
--disable-pip-version-checkwhen running pip from the test suite.In the best case, these checks are unnecessary and in the worst, they
cause tests to fail by emitting warnings.
Fixes #11114