Add default value to progress_bar option #11024
Open
+23
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Apr 11, 2022
| help="Specify whether the progress bar should be used [on, off] (default: on)", | ||
| choices=["auto", "on", "off"], | ||
| default="auto", | ||
| help="Specify whether the progress bar should be used [on, off] (default: auto)", |
There was a problem hiding this comment.
We should probably mention what auto means
There was a problem hiding this comment.
I’m thinking auto = inferred from -q; on = force on.
There was a problem hiding this comment.
Idk how to document it properly.
uranusjr
reviewed
Apr 11, 2022
| @@ -17,15 +23,17 @@ | |||
| from pip._internal.utils.logging import get_indentation | |||
|
|
|||
| DownloadProgressRenderer = Callable[[Iterable[bytes]], Iterator[bytes]] | |||
| RichBarType = Literal["auto", "on"] | |||
| BarType = Union[RichBarType, Literal["off"]] | |||
There was a problem hiding this comment.
Not really related to this change, but making BarType an enum would make validation much easier.
There was a problem hiding this comment.
but it would be tricky to use enum for argparse/optparse
uranusjr
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10930 (comment)