Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filename for windows FileNotFoundError #10819

Merged
merged 5 commits into from
Feb 3, 2022
Merged

Add filename for windows FileNotFoundError #10819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b8cea86
Add filename for windows FileNotFoundError
q0w Jan 21, 2022
b33da32
Reraise current exc
q0w Jan 25, 2022
cfcb4e9
Add changelog
q0w Jan 25, 2022
332e960
Check if there is no filename in exc
q0w Feb 3, 2022
7f6a9ca
Add test
q0w Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/10812.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Improve error message when ``pip config edit`` is provided an editor that
doesn't exist.
4 changes: 4 additions & 0 deletions src/pip/_internal/commands/configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,10 @@ def open_in_editor(self, options: Values, args: List[str]) -> None:

try:
subprocess.check_call([editor, fname])
except FileNotFoundError as e:
if not e.filename:
e.filename = editor
raise
except subprocess.CalledProcessError as e:
raise PipError(
"Editor Subprocess exited with exit code {}".format(e.returncode)
Expand Down
7 changes: 7 additions & 0 deletions tests/functional/test_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,3 +140,10 @@ def test_global_config_file(self, script: PipTestEnvironment) -> None:
global_config_file = get_configuration_files()[kinds.GLOBAL][0]
result = script.pip("config", "debug")
assert f"{global_config_file}, exists:" in result.stdout

def test_editor_does_not_exist(self, script: PipTestEnvironment) -> None:
"""Ensure that FileNotFoundError sets filename correctly"""
result = script.pip(
"config", "edit", "--editor", "notrealeditor", expect_error=True
)
assert "notrealeditor" in result.stderr