Document the new resolver #10247
Merged
Document the new resolver #10247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| that satisfy them. This is essentially where the finder interacts with the | ||
| resolver. | ||
| * `is_satisfied_by` - checks if a candidate satisfies a requirement. This is | ||
| basically the implementation of what a requirement meams. |
There was a problem hiding this comment.
Suggested change
| basically the implementation of what a requirement meams. | |
| basically the implementation of what a requirement means. |
Closed
github-actions
bot
added
the
needs rebase or merge
|
@pfmoore How do feel about rebasing this, adding a "work in progress" admonition on top of the document and merging this? |
|
Sounds like a reasonable idea. I'll try to get to it soon. |
|
OK, I merged in main and resolved the conflict, and I added a note to the doc. I'll leave this a day or two and if no-one has any issues with it I'll merge it. /cc @pradyunsg |
|
It's easy enough to revert or fix if anyone feels there's improvements to be made 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very much work in progress at the moment. Mostly putting it here so I can see how it renders in RTD.
Fixes #10240.