Add get_musl_major_minor from PEP 656. #10088
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
packaging
supports PEP 656 wheels (pypa/packaging#411), I think all that is necessary to allow pip to install them is to have the platform check pick up the platform tag.For example, right now
rpy2-3.4.5-cp39-cp39-musllinux_1_2_x86_64.whl
(tagcp39-cp39-musllinux_1_2_x86_64 @ 140319066709760
) seems ready to install except for the fact that, on an actual musllinux system,get_supported()
returns only[<cp39-cp39-linux_x86_64 @ 140319067309696>, <cp39-abi3-linux_x86_64 @ 140319066714880>, <cp39-none-linux_x86_64 @ 140319066715456>, <cp38-abi3-linux_x86_64 @ 140319066714240>, <cp37-abi3-linux_x86_64 @ 140319066715712>, <cp36-abi3-linux_x86_64 @ 140319066715968>, <cp35-abi3-linux_x86_64 @ 140319066716224>, <cp34-abi3-linux_x86_64 @ 140319066716480>, <cp33-abi3-linux_x86_64 @ 140319066716736>, <cp32-abi3-linux_x86_64 @ 140319066716992>, <py39-none-linux_x86_64 @ 140319066714304>, <py3-none-linux_x86_64 @ 140319066714688>, <py38-none-linux_x86_64 @ 140319066717696>, <py37-none-linux_x86_64 @ 140319066717952>, <py36-none-linux_x86_64 @ 140319066726464>, <py35-none-linux_x86_64 @ 140319066726720>, <py34-none-linux_x86_64 @ 140319066726976>, <py33-none-linux_x86_64 @ 140319066727232>, <py32-none-linux_x86_64 @ 140319066727488>, <py31-none-linux_x86_64 @ 140319066727744>, <py30-none-linux_x86_64 @ 140319066728000>, <cp39-none-any @ 140319066728512>, <py39-none-any @ 140319066728256>, <py3-none-any @ 140319066728768>, <py38-none-any @ 140319066729024>, <py37-none-any @ 140319066729280>, <py36-none-any @ 140319066729536>, <py35-none-any @ 140319066729792>, <py34-none-any @ 140319066730048>, <py33-none-any @ 140319066730304>, <py32-none-any @ 140319066730624>, <py31-none-any @ 140319066730880>, <py30-none-any @ 140319066731136>]
.By itself, this doesn't change any behavior. I haven't figured out the right place to slot into the various additions to the
supported
list. But if I'm on the right track at all, then we'll need theget_musl_major_minor
function from PEP 656 in compatibility_tags.py, and if not, then I'm on completely the wrong track.