Fix the pip/_internal/distributions annotations
#10074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This job started with my PR pypa#10004. When I started to replace the type commentaries into proper annotations. For this pull request, I'll take `pip/_internal/distributions`.
It is the respective news file for my pull request.
Convert type commentaries into proper annotations.
It was too long.
Fix the annotation length.
Fix an annotation like the black tests told me.
Convert type hint commentaries into proper annotations.
Specifying, fix the annotation length.
They used to be type commentaries.
They used to be type hint commentaries.
DiddiLeija
commented
Jun 16, 2021
Check the previous review for that.
Fix the annotations length.
Sorry, I made a really simple mistake with the annotations.
Fix the annotation length.
|
What do you think, @pypa committers, about this PR? |
|
Don’t tag pypa, that list contains a lot more people not related to pip. I’ll find some time to take a look at the changes sometime later this week. |
Oops. Sorry 🤦♂️. I'll take that in count for future comments 😄. |
|
Note: If you are landing here because of the pypa mention, I would like to apologize. You can ignore this, and even unsubscribe. |
1 task
|
Can an authorized pip commiter review my pull request? |
uranusjr
approved these changes
Jun 27, 2021
|
If you want, you can merge this pull request, after @uranusjr approved the changes. |
|
Hello, can somebody check this pull request to be merged? |
uranusjr
approved these changes
Jul 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This job started with my PR #10004. When I started to replace the type commentaries into proper annotations. For this pull request, I'll take
pip/_internal/distributions.