Release 21.1.2 #10012
Release 21.1.2 #10012
Conversation
This adds a check before invoking 'egg_info' to make sure either setup.py or setup.cfg actually exists, and emit a clearer error message when neither can be found and the egg_info command can never succeed.
This change ensures that when pip is executed from a wheel/zip, standalone pip creation for build environment reuses the source. Resolves: pypa#9953 Co-authored-by: Tzu-ping Chung <[email protected]>
Co-authored-by: Tzu-ping Chung <[email protected]>
Co-authored-by: Tzu-ping Chung <[email protected]>
The resolver collects previously known incompatibilites and sends them to the provider. But previously the provider does not correctly exclude the currently-installed candidate if it is present in that incompatibility list, causing the resolver to enter a loop trying that same candidate. This patch correctly applies incompat_ids when producing an AlreadyInstalledCandidate and exclude it if its id() is in the set.
It looks like towncrier unconditionally writes top_line when it is defined in the title_format configuration. So we must not repeat it in the template. When running towncrier with --draft, it works differently so in that case the top line is not shown...
sbidoul
added
skip news
| @@ -1,6 +1,6 @@ | |||
| {% set underline = "=" %} | |||
| {{ top_line }} | |||
There was a problem hiding this comment.
@pradyunsg @sbidoul FYI this change has completely removed the draft release title. See: https://pip.pypa.io/en/stable/news/
There was a problem hiding this comment.
Ah, that is interesting. I wanted to fix the release process which produced a duplicate title.
From a quick look at the towncrier source code I could not find a way to make it work consistently in draft and non draft mode when title_format is set in [tools.towncrier]. There must be something I misunderstand in towncrier... or it is bug, idk. Or perhaps the part of our toolchain that uses it in draft mode (where is that?) could generate the title?
There was a problem hiding this comment.
Yea, well, I prefer that to a duplicated heading in the release docs. :)
There was a problem hiding this comment.
@sbidoul this is probably a towncrier bug because the behavior changed with the latest release.
There was a problem hiding this comment.
The Towncrier regression makes normal and draft runs produce different outputs: twisted/towncrier#105. Possible upstream fix: twisted/towncrier#303.
Also, fix the towncrier template.