Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually flip the switch on the new resolver #8937

Closed
pradyunsg opened this issue Sep 29, 2020 · 6 comments
Closed

Actually flip the switch on the new resolver #8937

pradyunsg opened this issue Sep 29, 2020 · 6 comments
Labels
!release blocker Hold a release until this is resolved
Milestone

Comments

@pradyunsg
Copy link
Member

We're rolling out the new resolver as part of pip 20.3, and we need to flip the flags so that the new resolver is used by default in pip, with the old resolver being available behind --use-deprecated-feature=legacy-resolver as decided in #8371.

Roughly, the things that need to be done for this are:

  • Update the conditionals in the codebase to switch the default behavior.
  • Update the tests, to correctly handle the new resolver vs old resolver (run with new resolver by default).
  • Update the documentation, to denote that the new resolver is the default.
@sbidoul
Copy link
Member

sbidoul commented Oct 25, 2020

@pradyunsg @brainwane @pfmoore @uranusjr following #8664 (comment) and the next in the same thread, I'd suggest considering to never make the new resolver the default for python 2.

Especially since 20.3 is the last release to support python 2 it may be better to avoid creating unnecessary troubles for a version that we'll stop supporting soon.

@uranusjr
Copy link
Member

I am +0 on the proposal. It has always seemed awkward to me that the default resolver switch happens only one major version before Python 2 support is dropped entirely.

@pradyunsg
Copy link
Member Author

I think that'll work well, especially since we're dropping support in the next release (which, given our approach to branching+releases) means we can start dropping Python 2 support in master immediately after 20.3 is released.

brainwane added a commit to brainwane/pip that referenced this issue Oct 26, 2020
In pip 20.3, the new resolver will be the default.
Therefore, this commit updates user docs to change
instructions for testing, migration, etc.

Towards pypa#8937.
@brainwane
Copy link
Contributor

@sbidoul I think you have enough consensus here to go ahead -- could you start a PR to make that change?

@sbidoul
Copy link
Member

sbidoul commented Oct 26, 2020

@brainwane I'd love to but I'm afraid I don't have the bandwidth to work on that in the short term.

brainwane added a commit to brainwane/pip that referenced this issue Oct 27, 2020
In pip 20.3, the new resolver will be the default.
Therefore, this commit updates user docs to change
instructions for testing, migration, etc.

Towards pypa#8937.
brainwane added a commit to brainwane/pip that referenced this issue Oct 28, 2020
In pip 20.3, the new resolver will be the default.
Therefore, this commit updates user docs to change
instructions for testing, migration, etc.

Towards pypa#8937.
brainwane added a commit to brainwane/pip that referenced this issue Oct 29, 2020
In pip 20.3, the new resolver will be the default.
Therefore, this commit updates user docs to change
instructions for testing, migration, etc.

Towards pypa#8937.
@pradyunsg
Copy link
Member Author

With #9044 and #9019, this is now done! ^>^

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
!release blocker Hold a release until this is resolved
Projects
None yet
Development

No branches or pull requests

4 participants