-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pip not uninstalling previous versions when installing directly from a wheel path/url #1825
Comments
yes, I can confirm this. btw, installing directly from sdist does not have this problem. I'll take a look at fixing this. |
This is probably a big enough bug to issue another 1.5.x I think? |
+1 for another 1.5.x |
I think I have a fix for this. |
If we're doing another 1.5.x, can we revendor distlib? I'll try to get together a PR for that this evening, if nobody beats me to it :-) |
Sure. |
Added a 1.5.7 to organise things to put in it~ |
afaict, this has been a wheel bug from the beginning, so not sure it really qualifies for a patch release, but if people want to do a 1.5.7 for this, that's fine. |
if we're really doing the 1.5.7, I need to redo #1831 against 1.5.X |
I don't have much of an opinion on whether or not to do more point releases on 1.5, but organising issues into milestones doesn't cost anything so it's just a why not, in case :) |
I'm going to close this, I don't think we're going to do a 1.5.7 at this point and this is fixed in develop. |
Reproducible with pip 1.5.6 as follows:
Contents of setup.py used:
The previous version remains in site-packages and "Foo" can be uninstalled twice.
If I install Foo as a wheel first and the next version as sdist, the old version is uninstalled properly.
If I install the sdist first and wheel later, I get two Foos in site-packages.
Thus I conclude that wheel installation does not check for an existing installation.
I'm not even sure this bug belongs to pip.
The text was updated successfully, but these errors were encountered: