Skip to content

Commit

Permalink
Intentionally delay resolving setuptools
Browse files Browse the repository at this point in the history
  • Loading branch information
uranusjr committed Dec 9, 2020
1 parent 643217b commit b328c03
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion src/pip/_internal/resolution/resolvelib/provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,18 @@ def _get_restrictive_rating(requirements):
restrictive = _get_restrictive_rating(req for req, _ in information)
transitive = all(parent is not None for _, parent in information)
key = next(iter(candidates)).name if candidates else ""
return (restrictive, transitive, key)

# HACK: Setuptools have a very long and solid backward compatibility
# track record, and extremely few project would request a narrow,
# non-recent version range of it since that would break a lot packages.
# (Most projects specify it only to request for an installer feature,
# which does not work, but that's another topic.) Intentionally
# delaying Setuptools helps reduce branches the resolver has to check.
# This serves as a temporary fix for issues like "apache-airlfow[all]"
# while we work on "proper" branch-prunning techniques.
delay_this = (key == "setuptools")

return (delay_this, restrictive, transitive, key)

def find_matches(self, requirements):
# type: (Sequence[Requirement]) -> Iterable[Candidate]
Expand Down

0 comments on commit b328c03

Please sign in to comment.