Merge pull request #9315 from pradyunsg/better-search-errors

pypa · Dec 27, 2020 · 7e609a0 · 7e609a0
2 parents 2aea6e8 + e6d2bb2
commit 7e609a0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/news/9315.feature.rst b/news/9315.feature.rst
@@ -0,0 +1 @@
+Improve presentation of XMLRPC errors in pip search.
diff --git a/src/pip/_internal/commands/search.py b/src/pip/_internal/commands/search.py
@@ -77,7 +77,14 @@ def search(self, query, options):
 
         transport = PipXmlrpcTransport(index_url, session)
         pypi = xmlrpc_client.ServerProxy(index_url, transport)
-        hits = pypi.search({'name': query, 'summary': query}, 'or')
+        try:
+            hits = pypi.search({'name': query, 'summary': query}, 'or')
+        except xmlrpc_client.Fault as fault:
+            message = "XMLRPC request failed [code: {code}]\n{string}".format(
+                code=fault.faultCode,
+                string=fault.faultString,
+            )
+            raise CommandError(message)
         return hits
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Improve presentation of XMLRPC errors in pip search.