Consider success flag instead of absence of exception

pypa · Aug 13, 2020 · 4c348cf · 4c348cf
1 parent 03d49da
commit 4c348cf
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/src/pip/_internal/req/req_install.py b/src/pip/_internal/req/req_install.py
@@ -860,21 +860,21 @@ def install(
         except Exception:
             self.install_succeeded = True
             raise
-        else:
-            if self.legacy_install_reason == 8368:
-                deprecated(
-                    reason=(
-                        "{} was installed using the legacy 'setup.py install' "
-                        "method, because a wheel could not be built for it.".
-                        format(self.name)
-                    ),
-                    replacement="to fix the wheel build issue reported above",
-                    gone_in="21.0",
-                    issue=8368,
-                )
 
         self.install_succeeded = success
 
+        if success and self.legacy_install_reason == 8368:
+            deprecated(
+                reason=(
+                    "{} was installed using the legacy 'setup.py install' "
+                    "method, because a wheel could not be built for it.".
+                    format(self.name)
+                ),
+                replacement="to fix the wheel build issue reported above",
+                gone_in="21.0",
+                issue=8368,
+            )
+
 
 def check_invalid_constraint_type(req):
     # type: (InstallRequirement) -> str