Appply some refurb suggestions #759
Conversation
[FURB108]: Replace `x == y or x == z` with `x in (y, z)`
[FURB109]: Replace `in [x, y, z]` with `in (x, y, z)`
[FURB110]: Replace `x if x else y` with `x or y`
DimitriPapadopoulos
force-pushed
the
refurb
branch
3 times, most recently
from
9fe2d99 to
dc8c723
Compare
DimitriPapadopoulos
force-pushed
the
refurb
branch
3 times, most recently
from
fe44d0a to
2b98f34
Compare
[FURB142]: Replace `for x in y: s.add(...)` with `s.update(... for x in y)`
[FURB179]: Replace `itertools.chain(*x)` with `itertools.chain.from_iterable(x)`
[FURB180]: Replace `metaclass=abc.ABCMeta` with `abc.ABC`
DimitriPapadopoulos
force-pushed
the
refurb
branch
from
2b98f34 to
f7cdef4
Compare
|
Thanks for the PR, but it feels a bit noisy, e.g. changing lists to tuples that don't need to be changed. I'm going to close this, but if you think there's something I'm missing then please let us know or open a more targeted PR. |
There was a problem hiding this comment.
@brettcannon I can understand for changing lists to tuples, perhaps this one should be left out. The rest of the suggestions look like good ideas. The idea was to silence more ruff issue before adding a couple rules to jaraco/skeleton, for consistency across pypa projects. flake8-bugbear (B) rules are arguably more interesting, the tool has found two errors in the test code.
| @@ -38,7 +38,7 @@ def __init__(self, requirement_string: str) -> None: | |||
|
|
|||
| self.name: str = parsed.name | |||
| self.url: Optional[str] = parsed.url or None | |||
| self.extras: Set[str] = set(parsed.extras if parsed.extras else []) | |||
| self.extras: Set[str] = set(parsed.extras or []) | |||
There was a problem hiding this comment.
You should at least keep this one.
| @@ -235,8 +235,7 @@ def test_specifiers_hash(self, specifier): | |||
|
|
|||
| @pytest.mark.parametrize( | |||
| ("left", "right", "op"), | |||
| itertools.chain( | |||
| * | |||
| itertools.chain.from_iterable( | |||
There was a problem hiding this comment.
The following series of chain.from_iterable looks interesting to me as well.
Then please open another PR w/ just those changes. |
No description provided.