Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

direct-url: Wrap pip commands with backticks #973

Merged
merged 4 commits into from
Sep 3, 2021
Merged

Conversation

dukecat0
Copy link
Member

@dukecat0 dukecat0 commented Sep 2, 2021

Found this issue when fixing broken links.

@bhrutledge bhrutledge changed the title Add backquotes for commands direct-url: Add backquotes for pip commands Sep 2, 2021
source/specifications/direct-url.rst Show resolved Hide resolved
source/specifications/direct-url.rst Show resolved Hide resolved
Co-authored-by: Brian Rutledge <[email protected]>
@webknjaz webknjaz dismissed bhrutledge’s stale review September 2, 2021 17:43

Let's not block this PR on the rendering issues, it solves the problem it's meant to solve (making sure that linkcheck doesn't attempt to follow the fake URLs)

@webknjaz webknjaz requested a review from bhrutledge September 2, 2021 17:44
@webknjaz webknjaz changed the title direct-url: Add backquotes for pip commands direct-url: Wrap pip commands with backticks Sep 2, 2021
@dukecat0 dukecat0 requested a review from webknjaz September 3, 2021 10:32
@webknjaz webknjaz merged commit 55b8b32 into pypa:main Sep 3, 2021
@dukecat0 dukecat0 deleted the patch-1 branch September 3, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants