-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page "How to modernize a setup.py project?" #1371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for working on this @sinoroc .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sinoroc for this improvement.
2f2a185
to
fc17418
Compare
fc17418
to
ae74041
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @sinoroc. Merging 😄
Thanks all for the help! :) |
=================================== | ||
|
||
A :term:`pyproject.toml` file is strongly recommended. | ||
The presence of a :file:`pyproject.toml` file itself does not bring much. [#]_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized that this prompts an inaccuracy in my understanding of the matter. See pypa/sampleproject#204 (comment).
@sinoroc I think this deserves a clarification. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@webknjaz As I stated in the other discussion thread you linked, I do not understand the issue.
The important thing is the content of pyproject.toml
, first of all the build-system
table.
I have been told, and I have written it in this document, that simply having an empty pyproject.toml
triggers the "build isolation" behavior for pip (and other installers?). But that should be anecdotal nowadays (I heard it caused some issues at some point in the early days of PEP 517), isn't build isolation the default behavior for pip nowadays?
I am not sure how to improve this paragraph. Maybe we could move the whole sentence further down below or maybe even to a side note / foot note.
This is meant as a starting point. There is much more to say, and that can be said in follow-up pull requests.
Preview (but there were some small modifications on other pages as well, mainly links):
GitHub: refs #1334