Say that distribution names should be lowercase in wheel filenames #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you turn this into a draft, then? |
|
The Discourse thread has come to a conclusion in favour of making the normalisation more consistent, so I believe this can go ahead. |
henryiii
approved these changes
Jan 6, 2022
webknjaz
approved these changes
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should wait on the resolution of this Discourse thread about normalisation rules. I'm presuming it will come out in favour of keeping PEP 503 normalisation for wheel filenames.
This was an oversight on my part - I wanted the spec to directly describe the normalisation rule, not only refer to another spec, because I think this is clearer for people reading it. But I missed out the lower-casing step from PEP 503 in my description. The specs for
.dist-infoand for sdists both refer to PEP 503 without trying to copy the relevant details, so they don't have this issue.Given that name normalisation here is relatively new, we might want a note saying that tools consuming packages should be prepared to accept capital letters and dots in wheel filenames, because we can't really change names for existing packages.