Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing a Python package from Github fails #158

Closed
gkabbe opened this issue Jan 15, 2018 · 6 comments
Closed

Installing a Python package from Github fails #158

gkabbe opened this issue Jan 15, 2018 · 6 comments

Comments

@gkabbe
Copy link

gkabbe commented Jan 15, 2018

When I try to install a Flit package from Github, for example via

flit installfrom github:takluyver/flit

Flit only complains with the following message:

Neither pyproject.toml nor flit.ini found, and no other config file path specified

This also happens if I specify the full URL (https://github.com/takluyver/flit)

@takluyver
Copy link
Member

Oh, it's checking for that file before it goes into the installfrom subcommand. I think you can work around it by running the command from a directory that has a pyproject.toml file in. I'll fix it for the next release (and at some point, the installfrom command will be redundant once pip supports PEP 518).

@flying-sheep
Copy link
Contributor

now we’re stuck between a rock and a hard place: this is still an issue and pip still doesn’t support PEP 518 fully (i.e. still expects setup.py)

@takluyver
Copy link
Member

Paul Moore is working on PEP 517 support in pip.

But this is a separate issue: it should just skip the checks for the toml/ini files when you use installfrom.

@flying-sheep
Copy link
Contributor

flying-sheep commented Sep 5, 2018

exactly. right now the situation is that you can’t install a flit-powered package directly from a git repo in one short command. The options are

  1. git clone → pushd → flit install → popd → rm -rf (cumbersome)
  2. add a flituptools-based setup.py (bloat, confusing presence of a otherwise unnecessary setup.py)
  3. wait for this issue to be fixed and released (future)
  4. wait for pip with PEP 517 support to be released (future)

Is #206 already enough?

@takluyver
Copy link
Member

takluyver commented Sep 5, 2018 via email

@flying-sheep
Copy link
Contributor

true! but if #206 is enough, we could just quickly release 1.1.1 with that, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants