Coerce Distribution.script_args to list #320
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow any iterable to be passed as
script_args
forsetup
.After this is merged, typeshed can be updated to reflect this change, which will allow https://github.com/jaraco/jaraco.office/pull/2/files#diff-bb91dce3f1ce94166001a97817fed8d6a6a56c6d7f95233cc28268aea7f05778R24 to pass.
If you don't want the coercion, then
script_args
should at least be typed asSequence[str]
and python/typeshed#13116 should be merged first.I also noticed, I think there's no validation that
script_args
isn't a plainstr