-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional fields are really optional #138
Conversation
…nt warn when omitted), and stop coercing missing values to the string "UNKNOWN"
Overall, this looks good to me. Is there any way this change could be rolled out in such a way that it doesn't have to be synchronized with Setuptools? Perhaps to have a PR land there first? I'm concerned the coordination with Setuptools may be indicative of a compatibility issue with stdlib distutils. I'll check the Setuptools PR soon. |
687db4c
to
2c34a36
Compare
@jaraco IIUC you want the changes in setuptools to work regardless of whether it calls to pypa/distutils or stdlib distutils? |
That's correct. Setuptools still supports using stdlib distutils, so any change there will need to support both. If this change requires Setuptools to drop support for stdlib distutils, the change will have to wait until that happens (maybe this year). |
make all fields documented as optional in the spec truly optional (and don't spam warnings when they've been omitted)
stop coercing missing values to the string "UNKNOWN"
Note: the setuptools integration is expected to fail, because this PR needs to be coordinated with changes in
setuptools/dist.py
too. I'll prepare a separate PR on pypa/setuptools for that part.