-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding enable #2048
Merged
Merged
feat: adding enable #2048
+207
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
commented
Oct 19, 2024
henryiii
force-pushed
the
henryiii/feat/enable
branch
from
October 21, 2024 14:55
d7329df
to
a70d4b3
Compare
Merged
henryiii
force-pushed
the
henryiii/feat/enable
branch
from
October 22, 2024 14:17
a70d4b3
to
8a54c9f
Compare
henryiii
force-pushed
the
henryiii/feat/enable
branch
2 times, most recently
from
November 1, 2024 15:11
cc80f2c
to
bbc0a19
Compare
mayeut
reviewed
Nov 2, 2024
henryiii
force-pushed
the
henryiii/feat/enable
branch
from
November 6, 2024 04:46
bbc0a19
to
e2c5f24
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/enable
branch
from
November 6, 2024 04:55
e2c5f24
to
17df90f
Compare
Signed-off-by: Henry Schreiner <[email protected]>
There are too many warnings issued for a single build. I will push some commits to rework deprecation notices.
|
The warnings now show as:
|
mayeut
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2045. Adds
enable
, deprecates the old way of specifying these (remove in 3.0).