Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rust #1816

Merged
merged 8 commits into from
May 12, 2024
Merged

docs: rust #1816

merged 8 commits into from
May 12, 2024

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented May 10, 2024

Two related changes:

  • docs: add FAQ entry on Rust
  • ci: make readthedocs faster

Before, on readthedocs:

Screenshot 2024-05-10 at 1 12 09 AM

After:

Screenshot 2024-05-10 at 1 13 01 AM

Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
@henryiii
Copy link
Contributor Author

@mayeut, does this look okay?

docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
@mayeut
Copy link
Member

mayeut commented May 11, 2024

does this look okay?

I honestly don't know enough to give an informed feedback. All I can say is that it does not look wrong.
Maybe reach out to PyO3 ?

@henryiii
Copy link
Contributor Author

I've been testing in a branch of https://github.com/henryiii/pyproject-fmt-rust/tree/henryiii/ci/try-musl, so I think it's close.

Co-authored-by: Matthieu Darbois <[email protected]>
@henryiii
Copy link
Contributor Author

@davidhewitt, could you take a quick look at this? I suspect the pp* skip is wrong.

docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
@davidhewitt
Copy link

Is there an example project you used to test? Otherwise I can set one up for all OSes as an example.

PyPy should work fine; if it doesn't, I think it's a PyO3 bug.

@henryiii
Copy link
Contributor Author

henryiii commented May 11, 2024

This branch (the repo moved on to maturin-action): https://github.com/henryiii/pyproject-fmt-rust/tree/henryiii/ci/try-musl. I tried adding pypy again and started a build: https://github.com/henryiii/pyproject-fmt-rust/actions/runs/9042253197

I'm having an issue with 64-bit Windows pypy not being found in maturin-action, not sure what stage is failing, maturin-action, maturin, or pyo3. tox-dev/pyproject-fmt-rust#5

But it worked out of the box on UNIX, so worth checking with cibuildwheel.

@henryiii
Copy link
Contributor Author

PyPy works in cibuildwheel, including on Windows.

@henryiii henryiii merged commit 6dd4f15 into pypa:main May 12, 2024
18 of 19 checks passed
@henryiii henryiii deleted the henryiii/docs/rust branch May 12, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants