-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: rust #1816
docs: rust #1816
Conversation
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
@mayeut, does this look okay? |
I honestly don't know enough to give an informed feedback. All I can say is that it does not look wrong. |
I've been testing in a branch of https://github.com/henryiii/pyproject-fmt-rust/tree/henryiii/ci/try-musl, so I think it's close. |
Co-authored-by: Matthieu Darbois <[email protected]>
@davidhewitt, could you take a quick look at this? I suspect the |
Is there an example project you used to test? Otherwise I can set one up for all OSes as an example. PyPy should work fine; if it doesn't, I think it's a PyO3 bug. |
This branch (the repo moved on to maturin-action): https://github.com/henryiii/pyproject-fmt-rust/tree/henryiii/ci/try-musl. I tried adding pypy again and started a build: https://github.com/henryiii/pyproject-fmt-rust/actions/runs/9042253197 I'm having an issue with 64-bit Windows pypy not being found in maturin-action, not sure what stage is failing, maturin-action, maturin, or pyo3. tox-dev/pyproject-fmt-rust#5 But it worked out of the box on UNIX, so worth checking with cibuildwheel. |
PyPy works in cibuildwheel, including on Windows. |
Two related changes:
Before, on readthedocs:
After: