-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support macOS universal2 wheel fusion? #705
Comments
I'm +1 on this, that was one workflow that made sense to me #473 (comment) |
FWIW, multibuild is backtracking and will also create thin wheels. A problem was discovered with universal2 and NPY_SIZEOF_LONGDOUBLE and NPY_SIZEOF_COMPLEX_LONGDOUBLE for numpy, which was fixed in numpy/numpy#20270, but the problem may appear in other projects so it is safer to distribute separate wheels. |
Not true. multibuild has always created thin wheels and did wheel fusion. |
Yes, this is not related. NumPy is just shipping the thin wheels now. This issue is about wheel fusion, that is, making the thin wheels and then post processing them into a universal wheel, specifically making sure it's easy to do that combination step. |
As I commented elsewhere I don't really see the need for cibuildwheel to provide this option. I haven't heard a clear need for |
xref numpy/numpy#20787 |
In the future, would it make sense to support macOS universal2 wheel fusion, like multibuild does? Either automatically when all three arches are chosen, for example? Or maybe just provide an example how how to do it if you have the two dedicated wheels?
The text was updated successfully, but these errors were encountered: