-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Build musllinux
aarch64 and x86_64 wheels, and native macOS arm64 wheels
#719
CI: Build musllinux
aarch64 and x86_64 wheels, and native macOS arm64 wheels
#719
Conversation
bc5003a
to
4e69950
Compare
This should be ready for review now, please check the logs here: https://github.com/agriyakhetarpal/pywt/actions/runs/8255410993/job/22581797957 All job produce a singleton wheel, except for the GNU/Linux jobs that produce two – both musllinux and manylinux wheels. Edit: all jobs are passing! |
CI: exclude macOS runners based on architecture
4e69950
to
25d28dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks like it works as advertised, nice work @agriyakhetarpal. I only have a few minor comments for maintainability and future-proofing.
All wheels are getting built, please see this workflow run: https://github.com/agriyakhetarpal/pywt/actions/runs/8262339804 |
musllinux
aarch64 and x86_64 wheels, and native macOS arm64 wheelsmusllinux
aarch64 and x86_64 wheels, and native macOS arm64 wheels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! All looks good, so let's give it a go.
Description
This PR addresses the following:
macos-14
GitHub Actions runners to target macOS arm64 wheels natively, without cross-compilationbuild_linux_aarch64_wheels
andbuild_linux_x86_64_wheels
jobs to include MUSL wheels (which were previously being skipped).Footnotes
This PR: