Skip to content

Commit

Permalink
Customise merge behaviour depending on option. Fix #1803 (#1984)
Browse files Browse the repository at this point in the history 
Fix for #1803, where the method used for merging the config-settings option - string concatenation - was of little use.

I broke out the TableFmt object into a protocol-like object called OptionFormat, where the formatting and merge rules can be customised more deeply. This is more explicit, and lets us be a bit more precise with how TOML object get converted into the options.

I intend to use the flexibility of the OptionsFormat structure to tackle the remaining abiguity around environment variable quoting, as seen in the xfails in the options_test.py unit test and discussed in #1271.


Co-authored-by: Matthieu Darbois <[email protected]>
  • Loading branch information
@joerick @mayeut
joerick and mayeut authored Sep 3, 2024
1 parent 229029e commit ca08f5f
Show file tree
Hide file tree
Showing 3 changed files with 251 additions and 148 deletions.
Loading

0 comments on commit ca08f5f

Please sign in to comment.