build uninstalls setuptools even if needed by a dependency #231
Comments
astrojuanlu
changed the title
|
(Edit: Misleading reference to old issue, or so I think) |
|
Aghh, seems like pip is not building the dependencies in isolation. The dependencies should not be build in the build environment. They should be built separately and then installed onto the build environment. I think this is probably due to an old pip version. @gaborbernat do you know when did pip started building in isolation? |
|
I believe build isolation was introduced to pip with the PEP 517 implementation. |
|
Which project are you trying to build? Do you have a link? |
|
Sorry, you're referring to pypa/build itself, now I get it |
|
Looks like that pip should be recent enough 🤔 |
|
pip does not use isolation for |
I, uh... what? I've traced that back to flit 2.0 - I suggest requiring flit 3.0 at a minimum if you don't want to have all of your runtime dependencies installed at build time. As for the |
+1 on this, should be backwards compatible. |
In pypa#231 we discovered pip is not building some dependencies in isolation, it is using the build environment, which can become an issue since we remove setuptools from the environment. As suggested by @layday, this patch passes --use-pep517 to pip so that it builds in isolation, as recomended by PEP 517. Fixes pypa#231 Signed-off-by: Filipe Laíns <[email protected]>
In pypa#231 we discovered pip is not building some dependencies in isolation, it is using the build environment, which can become an issue since we remove setuptools from the environment. As suggested by @layday, this patch passes --use-pep517 to pip so that it builds in isolation, as recomended by PEP 517. Fixes pypa#231 Signed-off-by: Filipe Laíns <[email protected]>
In #231 we discovered pip is not building some dependencies in isolation, it is using the build environment, which can become an issue since we remove setuptools from the environment. As suggested by @layday, this patch passes --use-pep517 to pip so that it builds in isolation, as recomended by PEP 517. Fixes #231 Signed-off-by: Filipe Laíns <[email protected]>
You were totally right @layday , thanks! |
|
#232 should have fixed this anyway. |
This is a continuation of #109, although slightly different.Not really,setuptoolsis still installed in myvenvafter this happens. So, build isolation is working.I have a project that uses
flitas build backend, however some of its dependencies use setuptools as build backend. When I callpython -m build ., what I observe is:No module named 'setuptools'Example:
The text was updated successfully, but these errors were encountered: