Type annotate bandersnatch plugins #561
Conversation
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
==========================================
+ Coverage 78.77% 78.89% +0.12%
==========================================
Files 13 13
Lines 2035 2033 -2
Branches 289 289
==========================================
+ Hits 1603 1604 +1
+ Misses 326 324 -2
+ Partials 106 105 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks - Looks legit ... TIL ignore[override] ...
Can you please unblacklist the plugins directory on pre-commit here now please to get MyPy testing it: https://github.com/pypa/bandersnatch/blob/master/.pre-commit-config.yaml#L33 on CI
|
I also learned |
|
And I appreciate it. As someone who’s typed a lot of old code, I appreciate the difficulties. Typing code changes how you code moving forward. For the better I believe :) |
| """ | ||
| Remove all release versions that match any of the specified patterns. | ||
| """ | ||
| releases = metadata["releases"] | ||
| for version in list(releases.keys()): | ||
| if any(pattern.match(version) for pattern in self.patterns): | ||
| if any(pattern.match(version) for pattern in self.patterns): # type: ignore |
There was a problem hiding this comment.
Will be interested to see what the error is here.
There was a problem hiding this comment.
prerelease_name.py:41: error: Item "None" of "Optional[List[Pattern[str]]]" has no attribute "__iter__" (not iterable)
There was a problem hiding this comment.
Ahh - makes sense.
Yeah, here we just need to add another check for a None object and handle it. I’ll go back and look at type ignores before closing the issue and see if we can get rid of a few more.
Related: #15.
Type annotate the bandersnatch plugins.
@techalchemy, it would be nice if you could review this PR since you know these plugins the best. (Only if you have the time though)