Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create venv in configured directory #90

Merged
merged 1 commit into from
May 7, 2024

Conversation

nicholasjng
Copy link
Contributor

The option for VENV_EXISTS was hardcoded, which might have been an oversight given that the ability to override the venv is mentioned at the top of the file.

The option for VENV_EXISTS was hardcoded, which might have been an
oversight given that the ability to override the venv is mentioned
at the top of the file.
@nicholasjng nicholasjng requested a review from woodruffw as a code owner May 7, 2024 10:08
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that was an error, thanks!

@woodruffw woodruffw merged commit ca120ac into pypa:main May 7, 2024
11 checks passed
@nicholasjng nicholasjng deleted the make-venv branch May 7, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants