Add --version option to show abi3audit version information #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodruffw
reviewed
Nov 20, 2024
abi3audit/_cli.py
Outdated
Comment on lines
178
to
186
| parser.add_argument( | ||
| version_group = parser.add_argument_group() | ||
| version_group.add_argument( | ||
| "-V", | ||
| "--version", | ||
| action="store_true", | ||
| help="show abi3audit version information", | ||
| ) | ||
| main_group = parser.add_argument_group("main arguments") | ||
| main_group.add_argument( |
There was a problem hiding this comment.
I think this makes the parser a lot harder to follow -- could we use action='version' instead? That should handle everything automatically and avoid the need for separate arg groups.
For example:
parser.add_argument("-V", "--version", action='version', version=f"%(prog)s {__version__}")There was a problem hiding this comment.
Oh that's much better, I didn't know that argparse had built in support for version display.
|
Thanks @wsfulton! This is great to have, but I think we can do it with a one-line change instead of parser groups. See my suggestion above 🙂 |
woodruffw
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current output for new option in a commonly used output format of program name followed by version number: