Improve error message when .so file without .abi3. in it is specified
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Say that the file path must contain `.abi3.` and check that this is indeed the case in the corresponding test.
spec._extractor() raises ExtractorError if and when an error occurs and not an InvalidSpec, so handle this exception in the except clause. This ensures that we give the expected error instead of a full backtrace when specifying a non-existing file, for example.
Call make_specs() explicitly and handle exceptions from it in order to show the appropriate error message instead of letting argparse call it implicitly. As mentioned in that module documentation: > In general, the type keyword is a convenience that should only be used > for simple conversions that can only raise one of the three supported > exceptions. Anything with more interesting error-handling or resource > management should be done downstream after the arguments are parsed. And this is exactly what this commit does. Closes pypa#117.
Signed-off-by: William Woodruff <[email protected]>
Yeah, unfortunately we have no real CLI tests at the moment. Testing locally is helpful, thanks! |
woodruffw
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly done to fix #117, but also improves another error message which I noticed while making it.
Unfortunately I don't know how to add tests for the CLI behaviour and there doesn't seem to be any existing ones, so I've only tested this manually but at least it does seem to work as expected: