-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Warning for label_enable not set while using labels_only #202
Add Warning for label_enable not set while using labels_only #202
Conversation
This was intentionally left as it was to allow "turning off" label_enable temporarily. I feel as though this is better suited in the wiki under the labels_only section. If you would like to add a |
I see, that makes sense. What about setting label_enable to true only if it's omitted and labels_only is true? Setting it to false explicitly could still work, and we could then show the warning. |
false/commented out is personal preference. its much easier (read lazier) to just comment out the env line in compose than to type false. so i see that backfiring ya know? |
How we doing on this one |
…o labels-only-enables-labels
…to labels-only-enables-labels
Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
I spend a few minutes confused because I set labels_only to true, expecting labels to work. However, it required labels_enable to be set to true as well.
I don't see a scenario where setting labels_only but not enabling labels makes sense, so the update simply sets labels_enable to true if labels_only is true.