Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mypy to the end of pre-commit #3755

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

hoodmane
Copy link
Member

Mypy is much slower than any of the other checks so it should go last.

@cclauss
Copy link
Contributor

cclauss commented Apr 11, 2023

There is lots of talk about whether mypy should even be run in pre-commit:

I have started to remove if from pre-commit in projects but would be interested in your perspective.

@rth
Copy link
Member

rth commented Apr 11, 2023

There is lots of talk about whether mypy should even be run in pre-commit:

Yeah, I also have mixed feelings about it, but probably would still tend to use pre-commit for it as,

  • at least it's an env with fixed requirements that everyone uses, so much better for reproducibility.
  • I don't want to manually run it for each commit. In our case, forgetting to fix mypy before pushing then doing something else burns hours of CI CPU time. Pre-commit provides some guardrails against doing that.

@hoodmane hoodmane merged commit e309dfd into pyodide:main Apr 11, 2023
@hoodmane hoodmane deleted the pre-commit-mypy-last branch April 11, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants