Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT Move WheelInfo into a separate file #86

Merged
merged 11 commits into from
Sep 20, 2023
Merged

MAINT Move WheelInfo into a separate file #86

merged 11 commits into from
Sep 20, 2023

Conversation

ryanking13
Copy link
Member

This is a maintenance PR that includes the following:

  • Move WheelInfo class from transaction.py to wheelinfo.py.
  • Explicitly mark private methods of WheelInfo as private.
  • Improve test coverage of WheelInfo class.
  • Change ProjectInfo that returns from package_index.query_package to hold WheelInfo directly.

rth
rth approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this refactoring! Code wise LGTM.

Looks like there is one missing rename which makes a test fail.

@ryanking13
Copy link
Member Author

It looks like there was a regression in recent setuptools_scm release: pypa/setuptools-scm#905

@ryanking13 ryanking13 merged commit 0f0eb11 into pyodide:main Sep 20, 2023
5 checks passed
@ryanking13 ryanking13 deleted the merge-wheelinfo branch September 20, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanking13 @rth