[WIP] Handle yanked flag
#148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
reviewed
Oct 22, 2024
| @@ -157,13 +157,16 @@ def _compatible_wheels( | |||
| # This key is not available in the Simple API HTML response, so this field may be None | |||
| size = file.get("size") | |||
|
|
|||
| yanked = file.get("yanked") | |||
There was a problem hiding this comment.
I'd say you could just do:
if file.get("yanked"):
continuehere.
There was a problem hiding this comment.
I guess this wouldn't allow for
unless they are the only file that matches a version specifier that “pins” to an exact version using either == (without any modifiers that make it a range, such as .*) or ===.
So maybe handling later is better.
There was a problem hiding this comment.
Yes I think that rule would be implemented in find_wheel so the yanked value should be kept in WheelInfo and handled there.
|
Why did you close this? Are you going to make another? If you add a test it looks like something we could merge. |
|
Hmm I see your comment. Well thanks for looking into it @whitphx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #146
While this is still wip, let me create this PR to get reviews checking if it's in a right direction.
Could you check if this strategy is ok where I added
yankedfield toWheelInfoand use it to filter out the yanked wheels infind_wheel?TODO: