-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial package setup #1
Conversation
It does look like we have some misconfiguration for pre-commit, because it does find things to fix in code I copy-paster from the Pyodide repo. Where pre-commit should have been running on them (well at least for tests/test_micropip.py). And I think I saw that for matplotlib-pyodide as well. |
This reverts commit fde1164.
I think @henryiii specifically excluded the externals directory based on the idea that we didn't want to change code copied out of other projects. |
Yeah but for instance, in 851b14b triggered by pre-comit there is a linter change in |
Probably would be good to revert the changes to the externals directory. |
I did in earlier commits.. |
Sorry! Recently I have also been getting the following error:
|
Mostly boilerplate code to set up the package adapted from pytest-pyodide, matplotlib-pyodide etc.