Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial package setup #1

Merged
merged 5 commits into from
Sep 15, 2022
Merged

Initial package setup #1

merged 5 commits into from
Sep 15, 2022

Conversation

rth
Copy link
Member

@rth rth commented Sep 15, 2022

Mostly boilerplate code to set up the package adapted from pytest-pyodide, matplotlib-pyodide etc.

@rth
Copy link
Member Author

rth commented Sep 15, 2022

It does look like we have some misconfiguration for pre-commit, because it does find things to fix in code I copy-paster from the Pyodide repo. Where pre-commit should have been running on them (well at least for tests/test_micropip.py). And I think I saw that for matplotlib-pyodide as well.

@hoodmane
Copy link
Member

I think @henryiii specifically excluded the externals directory based on the idea that we didn't want to change code copied out of other projects.

@rth
Copy link
Member Author

rth commented Sep 15, 2022

Yeah but for instance, in 851b14b triggered by pre-comit there is a linter change in micropip/_micropip.py and in tests/test_micropip.py. So it's not just externals. With a monorepo it's hard to make sure that path regexes are correct everywhere, because there are so many things...

@hoodmane
Copy link
Member

Probably would be good to revert the changes to the externals directory.

@rth
Copy link
Member Author

rth commented Sep 15, 2022

I did in earlier commits..

@rth rth merged commit b47358d into pyodide:main Sep 15, 2022
@rth rth deleted the minimal-package-setup branch September 15, 2022 20:53
@hoodmane
Copy link
Member

hoodmane commented Sep 15, 2022

I did in earlier commits..

Sorry!

Recently I have also been getting the following error:

/home/hood/.cache/pre-commit/repow1xom7p_/py_env-3.10/lib/python3.10/site-packages/numpy/__init__.pyi:636: error:
Positional-only parameters are only supported in Python 3.8 and greater  [syntax]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants