-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate dockerfile and workflow for conda build [PART 2] #1540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't fix your errors, but will be important
I fixed the |
It seems |
We need to update the OpenMC statepoint file in Short term: update the statepoint version string in the H5 file and see if it works Long term: create an OpenMC input that generates that statepoint file - or some replacement |
@zxkjack123 - any chance you have the OpenMC input that generated the statepoint file for testing R2S? (see more above). We need to regenerate it with a newer version of OpenMC. |
I tried the short term solution of editing the statepoint file's version using There was another error for the conda build in Looks like all tests are passing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few changes I would like to request.
tests/files_test_r2s/r2s_examples/openmc_r2s/statepoint.nps5e5.ves8.ebins175.h5
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bquan0 - I'm glad all the tests pass now. After these changes, we'll need to look carefully through the test logs to make sure we're actually testing what we think and not getting false positives (which has been a problem in the past)
docker/conda_build.dockerfile
Outdated
ENV PYNE_MOAB_ARGS "--moab $HOME/opt/moab" | ||
ENV PYNE_DAGMC_ARGS "--dagmc $HOME/opt/dagmc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think conda installs these in this location. These are locations we use for manual install in the apt
version, but conda will put these elsewhere. You might not need to specify a path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally, I didn't have these args, but in a previous comment you told me to set these args so that the install looks for the MOAB and DAGMC. I can try removing them and also changing them to the respective conda directory.
From what I can tell, the tests for DAGMC and MOAB still run regardless of whether I set them or not, but I'm not 100% sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need these args, but either with no path or a different correct path. I think no path should be ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made that change and the tests are still passing (though I'm not sure if the DAGMC and MOAB tests are running)
Co-authored-by: Ahnaf Tahmid Chowdhury <[email protected]>
I've applied the suggestions except for the one about the MOAB and DAGMC build args for PyNE. @gonuke let me know what I should try for that. |
I can see that this finds MOAB and DAGMC during build and also runs relevant tests, so I think it's all good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bquan0.
@bquan0 - this failed on merge :( with a segfault in Python???? |
Important note: Numpy v2 will be released on Jun 16 2024 |
Description
This is a continuation of #1527, which was discontinued because we decided that we needed to update the versions of OpenMC, MOAB, and HDF5 for the apt build. This time, for the Conda build, we will not have separate stages for
moab, dagmc, openmc
, so there will only exist one image with all those dependencies.Motivation and Context
This allows people to build PyNE using Conda, which is an alternative to using apt.
This PR will also be the new PR to close #1515.
Changes
This PR adds
conda_build.dockerfile
, which lists all the steps for building PyNE with Conda. It also addsconda_docker.yml
, which runs the multistage build action on the dockerfile to build PyNE images with Conda.Other Information
I'm not sure if the multistage action is relevant anymore because we only have one stage before the
pyne
stage (this is because we build everything butpyne
in the first job, then buildpyne
in the BuildTest job). I guess it's still necessary for caching purposes in GHCR?