-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream branch PR: Install packages with Conda in Dockerfile #1509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for transferring this over @bquan0. I don't think this PR should include the build_test
workflow since they CI image won't be available for them to to succeed. That should be a separate PR - thoughts?
@@ -16,6 +16,10 @@ env: | |||
jobs: | |||
pyne_image_build: | |||
runs-on: ubuntu-latest | |||
strategy: | |||
matrix: | |||
pkg_mgr: ['apt', 'conda'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need both options here. For users relying on the VM, we can pick only one option - apt
is probably fine.
You're right, I'll revert the changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bquan0 - I look forward to the follow on work here and in conda-forge
Description
See #1508 for more details on all the changes.
This PR modifies
ubuntu_22.04-dev.dockerfile
to include separate stagesapt_deps
andconda-deps
to allow for packages to be downloaded by either the package manager apt or conda. It also makes various changes in the workflowsdocker_publish.yml
,build_test.yml
, andvirtualbox_image.yml
to accomodate those changes.Motivation and Context
This is the same PR as #1508, except that it's made from a branch on the
pyne
repo instead of my forked repo. This allows the workflows to build the images in thepyne
ghcr.io, which will allow us to see if thebuild_test.yml
will pass (sincebuild_test.yml
pulls images from the pyne ghcr.io to test).Behavior
New behavior is that the
build_test.yml
workflow should run instead of erroring out because it couldn't find the proper image from ghcr.io.Other Information
I noticed that in
virtualbox_image.yml
, we never make a VM from thehdf5
images. Is this something I should look into doing?Also, I was wondering if I should add some logic in
build_test.yml
to make it not run when the${{ github.repository_owner }}
isn'tpyne
because the workflow only uses images from thepyne
ghcr.io.Changelog file
All pull requests are required to update the CHANGELOG file with the PR. Your update can take different forms including: