Remove proprietary glyphname <> unicode conversion #4152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyMuPDF unnecessarily provides proprietary code for Unicode to glyph name conversion and back. This fix uses the built-in Python module "unicodedata" for providing the same functionality. Note that we import this module within the respective two functions. They are rarely used and thus this import shouldn't charge PyMuPDF's import with additional processing.
JorjMcKie
force-pushed
the
native-glyphnames
branch
from
e431216 to
f22d142
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyMuPDF unnecessarily provides proprietary code for Unicode to glyph name conversion and back. This fix uses the built-in Python module "unicodedata" for providing the same functionality. Note that we import this module within the respective two functions. They are rarely used and thus this import shouldn't be part of PyMuPDF's start-up processing.