Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a memory issue in page.get_drawings() #4110

Closed
wants to merge 1 commit into from

Conversation

ZLotusRain
Copy link

Fix a memory issue when using page.get_drawings() with pdf which contains lots of vector graphics

Copy link
Contributor

github-actions bot commented Dec 3, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ZLotusRain
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@ZLotusRain
Copy link
Author

recheck

github-actions bot added a commit that referenced this pull request Dec 3, 2024
@JorjMcKie
Copy link
Collaborator

Thank you for your submission. I am afraid we are unable to accept your PR however.

  • A minor problem is that you are changing many code lines that are not related to the problem you are addressing. While we are aware that the file contains hundreds of lines with trailing spaces, cleaning up code is a different task - and would have to include multiple code quality issues beyond this.
  • We did consider in-place updates of that list of dictionaries during development of the method. Our performance tests however have shown that this performs worse than creating a new list. So we decided against this.
  • You have not included details concerning your motivation. The additional memory needed by the new list only exists during the creation process and will be released after that. About how many additional MB / GB(?) are we talking here?

@JorjMcKie JorjMcKie closed this Dec 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants