Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update to use argb for MuPDF 1.25+ compatibility #4094

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix: update to use argb for MuPDF 1.25+ compatibility #4094

merged 1 commit into from
Nov 29, 2024

Conversation

chenrui333
Copy link
Contributor

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@chenrui333
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@chenrui333
Copy link
Contributor Author

recheck

github-actions bot added a commit that referenced this pull request Nov 28, 2024
@github-actions
@chenrui333 has signed the CLA in #4094
ee182f4
julian-smith-artifex-com
julian-smith-artifex-com approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@julian-smith-artifex-com julian-smith-artifex-com left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

[We also need to fix the similar code in the Python version of JM_make_spanlist(), but i'll do this separately.]

@julian-smith-artifex-com julian-smith-artifex-com merged commit 3443769 into pymupdf:main Nov 29, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@julian-smith-artifex-com julian-smith-artifex-com julian-smith-artifex-com approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @julian-smith-artifex-com