Modified util_make_irect() to capture area more robustly; #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
[I think that the failure of "Test quick" is due to a problem with the latest mupdf, and not this PR.] |
julian-smith-artifex-com
force-pushed
the
main
branch
from
91b8e68 to
60f4479
Compare
|
I've rebased this PR to get latest changes that fix test_quick. |
JorjMcKie
approved these changes
Nov 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue #3163.
This updates updates the area of the rectangle based on the floating point. Instead of simply typecasting from float to int, this function now floors the coordinates for the top left corner and ceils the coordinates for the bottom right corner.
This allows the function to more robustly detect the rectangle.