Revive Document.subset_fonts #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revive Document.subset_fonts We are assuring that the subset font is not empty by counting its Unicodes - which is not yet implemented. This fix replaces this by checking the glyph count.
|
I don't know what has been going wrong. It definitely is not the changes made by this fix. |
A commit to MuPDF master yesterday has broken 4 PyMuPDF tests. |
|
Have checked this PR locally and tests pass if bad mupdf commit is reverted, so will approve now. |
julian-smith-artifex-com
approved these changes
Dec 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were assuring that the generated subset font is not empty by counting its Unicodes - which is not yet implemented in rebased. This fix checks the glyph count instead.