Various fixes to work with latest MuPDF etc. #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were overwriting the FzPixmap's accessor methods with the new values.
New MuPDF raises mupdf.FzError* instead of RuntimeError.
…anguage2() if available. If not available we assert fail.
This addresses pymupdf#2861.
But allow errors on windows-x32 because pillow not available.
MuPDF now throws exception if CSS path has back-slashes.
Improved comments. Simple but untested valgrind support when running tests. Venv name includes cpu bits; avoids potential problems when reusing same venv between different cpu bits. In log(), cope with potential os.path.relpath() error on Windows. Added global `test_packages`, python packages required for PyMuPDF tests; excludes `pillow` on windows-x32 because not available.
Also added support for specifying `--build-isolation` when building PyMuPDF with pip. Also use gh_release.test_packages.
When running tests, we need to not install `pillow` if on windows-x32; this is
much easier to do in python, so we now use scripts/*.py instead of increasingly
obscure yml configuration.
.github/workflows/test-valgrind.yml
Use scripts/test.py.
.github/workflows/test_mupdf-master-branch.yml
.github/workflows/test_mupdf-release-branch.yml
.github/workflows/test_quick.yml
Use scripts/gh_release.py.
.github/workflows/test.yml
Removed because unused.
JorjMcKie
approved these changes
Dec 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More commits in this PR than ideal, but latest MuPDF has broken a few things, and we need various fixes.