keyword args and flake8 testing and fixes #2826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to constructors of Rect etc. Addresses pymupdf#2232.
There are still a couple of flake8 errors.
JorjMcKie
requested changes
Nov 21, 2023
There was a problem hiding this comment.
The change in line 133 of utils.py incorrectly translates "== None".
As per the flake8 test:
We are disabling 20 checks / accepting 20 deviations from a PEP8 compliance.
I disagree with several of them! At least when we are switching over to rebased as the primary implementation, we should not accept deviations that have no better reason than personal preferences.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.