-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix tests, stop using make_napari_viewer fixture #338
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
- Coverage 78.24% 78.14% -0.10%
==========================================
Files 13 13
Lines 625 627 +2
==========================================
+ Hits 489 490 +1
- Misses 136 137 +1 ☔ View full report in Codecov by Sentry. |
I see this one remaining test fail a lot too. Usually if I rerun it it goes away (will try now), but any idea what's going on there? |
Just curious, were you able to figure out where/when this marker got added in napari? |
Nope, not sure what changed in napari's last week release that affected this behavior (for sure not the |
for my tastes, this fix is to specific to something that napari is internally doing in their tests, and may well break again in the future. I just think we shouldn't be using |
pushed a change that stops using make_napari_viewer |
add
pytest.mark.enable_console