Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix tests, stop using make_napari_viewer fixture #338

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

fdrgsp
Copy link
Contributor

@fdrgsp fdrgsp commented Jul 16, 2024

add pytest.mark.enable_console

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.14%. Comparing base (2cca097) to head (c352af4).
Report is 1 commits behind head on main.

Files Patch % Lines
...napari_micromanager/_gui_objects/_stages_widget.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   78.24%   78.14%   -0.10%     
==========================================
  Files          13       13              
  Lines         625      627       +2     
==========================================
+ Hits          489      490       +1     
- Misses        136      137       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fdrgsp fdrgsp requested a review from tlambert03 July 16, 2024 23:34
@tlambert03
Copy link
Member

I see this one remaining test fail a lot too. Usually if I rerun it it goes away (will try now), but any idea what's going on there?

@tlambert03
Copy link
Member

Just curious, were you able to figure out where/when this marker got added in napari?

@fdrgsp
Copy link
Contributor Author

fdrgsp commented Jul 17, 2024

Just curious, were you able to figure out where/when this marker got added in napari?

Nope, not sure what changed in napari's last week release that affected this behavior (for sure not the make_napari_viewer method though, it has not been recently modified)...

@tlambert03
Copy link
Member

for my tastes, this fix is to specific to something that napari is internally doing in their tests, and may well break again in the future. I just think we shouldn't be using make_napari_viewer... will update

@tlambert03
Copy link
Member

pushed a change that stops using make_napari_viewer

@tlambert03 tlambert03 changed the title test: fix test: fix tests, stop using make_napari_viewer fixture Jul 17, 2024
@tlambert03 tlambert03 merged commit 6c895f3 into pymmcore-plus:main Jul 17, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants