Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/refactor get shows #9689

Merged
merged 6 commits into from
Jul 3, 2021
Merged

Feature/refactor get shows #9689

merged 6 commits into from
Jul 3, 2021

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Jul 3, 2021 •
edited
Loading

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

Should fix #9618

p0psicles added 6 commits July 3, 2021 12:14
@p0psicles
Lowered the cache invalidation to 6 hours.
0a0eb2e
@p0psicles
Refactored the getShows method.
bad2c05 
* all promisses are handled by the Promise.All().
* Collect all shows through pagination and then commit them to store.

This fixes and issue where we only added shows to the store, but never overwritten/merged existing shows.
* Error handled the writing to localStorage.
@p0psicles
Fixed typo
62dd01c
@p0psicles
limit back to 1000
5f7ce37
@p0psicles
Fix lint
fd8b08f
@p0psicles
Fix lint2
462257b
@p0psicles p0psicles merged commit a811715 into develop Jul 3, 2021
@p0psicles p0psicles deleted the feature/refactor-get-shows branch July 3, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@p0psicles