Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the CHANGE_* methods from medusa.config.py #8948

Merged
merged 14 commits into from
Jan 4, 2021

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Jan 2, 2021

Used these methods in set properties of their app variables.

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@medariox with the vueification we lost the ability to "hot-reload" the threads and their settings.
I used @Property now to accomplish the same as what we had in the server/web/config/handler.py routes.

@p0psicles
Copy link
Contributor Author

@medariox aah great. Another one of those "pyTest is running fine locally, but not on build slave"
Will have to give this another go later.

…x-start-thread-config-change

# Conflicts:
#	medusa/app.py
#	medusa/config.py
As from 6.2.0 it will error on `attrs() got an unexpected keyword argument 'eq'`
@p0psicles p0psicles merged commit 27b0754 into develop Jan 4, 2021
@p0psicles p0psicles deleted the feature/fix-start-thread-config-change branch January 4, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant