Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode() bytes for saving into config.ini #8823

Merged
merged 5 commits into from
Dec 3, 2020

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Dec 2, 2020

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

Fix #8810

@p0psicles
Copy link
Contributor Author

@medariox the scecrets where stored as "binary". Like "b'sakljdflskdjflkdsjflksdfjldskjf'"
I suspect this was the issue. But should we create a config migration for this?

@medariox
Copy link
Contributor

medariox commented Dec 2, 2020

Hmm, I think there is something wrong with encode() and decode()... like the secret is getting decoded and encoded again, although it shouldn't if it is already encoded.

@medariox
Copy link
Contributor

medariox commented Dec 3, 2020

@p0psicles
No need for a migration as b'asasqqwqwe' and asasqqwqwe are both valid secrets. New installs won't have the b' prefix tho.

@medariox medariox added this to the 0.5.1 milestone Dec 3, 2020
@medariox medariox merged commit b2e131a into develop Dec 3, 2020
@medariox medariox deleted the feature/fix-encrypt-decrypt branch December 3, 2020 16:01
@p0psicles p0psicles restored the feature/fix-encrypt-decrypt branch December 3, 2020 16:02
@medariox medariox deleted the feature/fix-encrypt-decrypt branch December 16, 2020 17:27
coptere pushed a commit to coptere/Medusa that referenced this pull request Jan 27, 2021
* decode() bytes for saving into config.ini

* Deprecate "encryption v1"

* sort to fix tests

* :(

* :((

Co-authored-by: Dario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants