Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/always use indexer session #8813

Merged
merged 5 commits into from
Dec 1, 2020

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Dec 1, 2020

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

Make sure all indexers allways use the IndexerSession() class.

The Imdb request is raising an OsError exception. Using Exception to catch all, as I don't know what other exceptions can be thrown besides LookupError. Don't want it to impact the AddShow thread.

@p0psicles p0psicles merged commit 936c3cd into develop Dec 1, 2020
@p0psicles p0psicles deleted the feature/always-use-indexer-session branch December 1, 2020 21:10
coptere pushed a commit to coptere/Medusa that referenced this pull request Jan 27, 2021
* Make sure that for indexers the IndexerSession() is always used.

* Catch all imdb exceptions.

* Just use Exception

* Check for zero height or width

* Flake lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant